Don't bailout of type inference for simple NSM implementations

Don't bailout of type inference for simple NSM implementations

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44651

[Harry Terkelsen, 2015-03-23 18:00:55]

het@google.com changed reviewers:
+ johnniwinther@google.com, sra@google.com

[Harry Terkelsen, 2015-03-23 19:50:56]

het@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-03-23 21:02:26]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-03-23 21:02:27]

LGTM with comment.

https://codereview.chromium.org/1020853007/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/1020853007/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:768:
inferrer.backend.noSuchMethodRegistry.otherImpls.contains(e);
Don't just reach into the nsm-registry. Make a method.

https://codereview.chromium.org/1020853007/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart (right):

https://codereview.chromium.org/1020853007/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart:100: // We can
ignore because we know this throws
Missing ".", and I have the impression this isn't great English.

https://codereview.chromium.org/1020853007/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart:132: // We can
ignore
unfinished comment.

[Harry Terkelsen, 2015-03-23 22:31:18]

Thanks Florian, PTAL since I moved some things around

https://codereview.chromium.org/1020853007/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right):

https://codereview.chromium.org/1020853007/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:768:
inferrer.backend.noSuchMethodRegistry.otherImpls.contains(e);
On 2015/03/23 21:02:27, floitsch wrote:
> Don't just reach into the nsm-registry. Make a method.

Done.

https://codereview.chromium.org/1020853007/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart (right):

https://codereview.chromium.org/1020853007/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart:100: // We can
ignore because we know this throws
On 2015/03/23 21:02:27, floitsch wrote:
> Missing ".", and I have the impression this isn't great English.

Done.

https://codereview.chromium.org/1020853007/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart:132: // We can
ignore
On 2015/03/23 21:02:27, floitsch wrote:
> unfinished comment.

Done.

[floitsch, 2015-03-23 22:34:43]

LGTM.

https://codereview.chromium.org/1020853007/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/no_such_method_registry.dart (right):

https://codereview.chromium.org/1020853007/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/no_such_method_registry.dart:69: bool
isComplex(FunctionElement element) => otherImpls.contains(element);
Add dartdoc.
assert, that the element is a nsm.

[Harry Terkelsen, 2015-03-23 23:24:28]

The CQ bit was unchecked by het@google.com

[Harry Terkelsen, 2015-03-23 23:24:28]

The CQ bit was checked by het@google.com

[Harry Terkelsen, 2015-03-23 23:24:28]

The CQ bit was checked by het@google.com

[Harry Terkelsen, 2015-03-23 23:24:29]

The CQ bit was unchecked by het@google.com

[Harry Terkelsen, 2015-03-24 00:10:29]

https://codereview.chromium.org/1020853007/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/no_such_method_registry.dart (right):

https://codereview.chromium.org/1020853007/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/no_such_method_registry.dart:69: bool
isComplex(FunctionElement element) => otherImpls.contains(element);
On 2015/03/23 22:34:42, floitsch wrote:
> Add dartdoc.
> assert, that the element is a nsm.

Done.

[Harry Terkelsen, 2015-03-24 00:11:05]

Committed patchset #5 (id:80001) manually as 44651 (presubmit successful).