Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1020853004: Don't generate invocation mirror code if all noSuchMethods forward to (Closed)

Created:
5 years, 9 months ago by Harry Terkelsen
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Don't generate invocation mirror code if all noSuchMethods forward to Object.noSuchMethod BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=44606

Patch Set 1 #

Total comments: 2

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -27 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 3 chunks +8 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 5 chunks +16 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +19 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +167 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/compiler/dart2js/no_such_method_enabled_test.dart View 1 1 chunk +222 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Harry Terkelsen
The tests were failing because I failed to account for the case of `noSuchMethod(x, [y])` ...
5 years, 9 months ago (2015-03-19 17:27:28 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/1020853004/diff/1/tests/compiler/dart2js/no_such_method_enabled_test.dart File tests/compiler/dart2js/no_such_method_enabled_test.dart (right): https://codereview.chromium.org/1020853004/diff/1/tests/compiler/dart2js/no_such_method_enabled_test.dart#newcode190 tests/compiler/dart2js/no_such_method_enabled_test.dart:190: } Add a test for class A { ...
5 years, 9 months ago (2015-03-20 14:08:55 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1020853004/diff/1/tests/compiler/dart2js/no_such_method_enabled_test.dart File tests/compiler/dart2js/no_such_method_enabled_test.dart (right): https://codereview.chromium.org/1020853004/diff/1/tests/compiler/dart2js/no_such_method_enabled_test.dart#newcode190 tests/compiler/dart2js/no_such_method_enabled_test.dart:190: } On 2015/03/20 14:08:55, Johnni Winther wrote: > Add ...
5 years, 9 months ago (2015-03-20 18:18:04 UTC) #4
Harry Terkelsen
5 years, 9 months ago (2015-03-20 18:19:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698