Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1020853003: Split HForeign into HForeignCode and abstract base class. (Closed)

Created:
5 years, 9 months ago by herhut
Modified:
5 years, 7 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Split HForeign into HForeignCode and abstract base class. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=44602

Patch Set 1 #

Patch Set 2 : Formatting #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -54 lines) Patch
M pkg/compiler/lib/src/native/ssa.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 10 chunks +35 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 5 chunks +23 lines, -14 lines 2 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
herhut
PTAL
5 years, 9 months ago (2015-03-19 13:19:08 UTC) #1
Johnni Winther
lgtm
5 years, 9 months ago (2015-03-19 13:32:36 UTC) #2
herhut
Committed patchset #2 (id:20001) manually as 44602 (presubmit successful).
5 years, 9 months ago (2015-03-20 13:00:57 UTC) #3
sra1
https://chromiumcodereview.appspot.com/1020853003/diff/20001/pkg/compiler/lib/src/ssa/nodes.dart File pkg/compiler/lib/src/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/1020853003/diff/20001/pkg/compiler/lib/src/ssa/nodes.dart#newcode1729 pkg/compiler/lib/src/ssa/nodes.dart:1729: if(codeTemplate == null) throw this; space after 'if'
5 years, 9 months ago (2015-03-24 03:00:47 UTC) #5
herhut
5 years, 7 months ago (2015-05-26 14:32:18 UTC) #6
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1020853003/diff/20001/pkg/compiler/lib...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/1020853003/diff/20001/pkg/compiler/lib...
pkg/compiler/lib/src/ssa/nodes.dart:1729: if(codeTemplate == null) throw this;
On 2015/03/24 03:00:47, sra1 wrote:
> space after 'if'

This has been fixed in the meanwhile.

Powered by Google App Engine
This is Rietveld 408576698