- Use canonicalized type of non-parameterized classes when

- Use canonicalized type of non-parameterized classes when
  available.
- Do not attempt to make types for objects of Context.

R=fschneider@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31194

[Ivan Posva, 2013-12-16 23:50:35]

Accessing runtimeType of a non-parameterized class improves 3.5x and avoids a
lot of allocations.

-Ivan

[regis, 2013-12-17 08:39:03]

LGTM!

[Florian Schneider, 2013-12-17 10:39:23]

lgtm

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
runtime/vm/flow_graph_type_propagator.cc:811: return CompileType::Dynamic();
Correct, but I think the cid can be more precise. Something like this should
work:

CompileType(/*nullable=*/ false,
            kContextCid,
            &AbstractType::ZoneHandle(Type::DynamicType())

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
runtime/vm/flow_graph_type_propagator.cc:816: return CompileType::Dynamic();
Same here.

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
runtime/vm/flow_graph_type_propagator.cc:821: return CompileType::Dynamic();
And here.

https://codereview.chromium.org/102053010/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/102053010/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:11987: 
#undef RAW_NULL?

[Ivan Posva, 2013-12-17 16:58:03]

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
runtime/vm/flow_graph_type_propagator.cc:811: return CompileType::Dynamic();
On 2013/12/17 10:39:23, Florian Schneider wrote:
> Correct, but I think the cid can be more precise. Something like this should
> work:
> 
> CompileType(/*nullable=*/ false,
>             kContextCid,
>             &AbstractType::ZoneHandle(Type::DynamicType())

Done.

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
runtime/vm/flow_graph_type_propagator.cc:816: return CompileType::Dynamic();
On 2013/12/17 10:39:23, Florian Schneider wrote:
> Same here.

Done.

https://codereview.chromium.org/102053010/diff/1/runtime/vm/flow_graph_type_p...
runtime/vm/flow_graph_type_propagator.cc:821: return CompileType::Dynamic();
On 2013/12/17 10:39:23, Florian Schneider wrote:
> And here.

Done.

https://codereview.chromium.org/102053010/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/102053010/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:11987: 
On 2013/12/17 10:39:23, Florian Schneider wrote:
> #undef RAW_NULL?

I expect to get more of these kinds of tests in the future and either we keep
the RAW_NULL usage to only the initialization above or allow it for the whole
.cc file. The limitation half-way through the file would be just arbitrary.

[Ivan Posva, 2013-12-17 16:59:20]

Committed patchset #2 manually as r31194 (presubmit successful).