Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102033004: Enable more ciphers, and TLS 1.2, in SecureSocket. (Closed)

Created:
7 years ago by Bill Hesse
Modified:
7 years ago
Reviewers:
Anders Johnsen, wtc
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable more ciphers, and TLS 1.2, in SecureSocket. BUG=dartbug.com/14646 R=ajohnsen@google.com, wtc@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=30897

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -7 lines) Patch
M runtime/bin/secure_socket.cc View 2 chunks +32 lines, -7 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
Removing SSL_ENABLE_TLS because TLS is enabled by the set version range function.
7 years ago (2013-12-03 21:45:30 UTC) #1
wtc
Patch set 1 LGTM.
7 years ago (2013-12-03 21:54:34 UTC) #2
Anders Johnsen
lgtm https://codereview.chromium.org/102033004/diff/1/runtime/bin/secure_socket.cc File runtime/bin/secure_socket.cc (right): https://codereview.chromium.org/102033004/diff/1/runtime/bin/secure_socket.cc#newcode592 runtime/bin/secure_socket.cc:592: const PRUint16* const ssl_ciphers = SSL_GetImplementedCiphers(); Do we ...
7 years ago (2013-12-04 10:08:56 UTC) #3
wtc
https://codereview.chromium.org/102033004/diff/1/runtime/bin/secure_socket.cc File runtime/bin/secure_socket.cc (right): https://codereview.chromium.org/102033004/diff/1/runtime/bin/secure_socket.cc#newcode592 runtime/bin/secure_socket.cc:592: const PRUint16* const ssl_ciphers = SSL_GetImplementedCiphers(); On 2013/12/04 10:08:57, ...
7 years ago (2013-12-04 14:35:16 UTC) #4
Bill Hesse
7 years ago (2013-12-05 16:30:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r30897 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698