Issue 1020243004: Report separate UNUSED_CATCH_CLAUSE and UNUSED_CATCH_STACK hints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1020243004: Report separate UNUSED_CATCH_CLAUSE and UNUSED_CATCH_STACK hints. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -13 lines)			Patch
M	pkg/analysis_server/test/services/correction/fix_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1	5 chunks	+53 lines, -9 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1	3 chunks	+32 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Brian Wilkerson

LGTM once we've confirmed that the hints we're seeing in existing code are not false ...

5 years, 9 months ago (2015-03-20 23:43:34 UTC) #2

scheglov

5 years, 9 months ago (2015-03-23 16:41:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44635 (presubmit successful).