Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1019923005: Dart2js deferred loading. Follow types of functions when calculating dependencies. (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Dart2js deferred loading. Follow types of functions when calculating dependencies. This fixes part of dartbug.com/22995 Turns out that synthesized constructors not always have a type. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45086 Reverted in r45086 Committed: https://code.google.com/p/dart/source/detail?r=45101 Reverted in 45106 Committed: https://code.google.com/p/dart/source/detail?r=45159

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix indentation #

Total comments: 2

Patch Set 3 : Responding to review + Adding a computeSignature call. #

Total comments: 2

Patch Set 4 : Fixing problem in typechecker #

Patch Set 5 : Added regression test #

Patch Set 6 : Added test for generic type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -25 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 1 2 3 2 chunks +31 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 2 chunks +26 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
A + tests/language/deferred_regression_22995_lib.dart View 1 2 3 4 5 1 chunk +6 lines, -6 lines 0 comments Download
A tests/language/deferred_regression_22995_test.dart View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (3 generated)
sigurdm
5 years, 8 months ago (2015-04-10 13:28:05 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/1019923005/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1019923005/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode2048 pkg/compiler/lib/src/elements/modelx.dart:2048: this.definingConstructor, Bad indent.
5 years, 8 months ago (2015-04-10 13:37:16 UTC) #4
sigurdm
https://codereview.chromium.org/1019923005/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (right): https://codereview.chromium.org/1019923005/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#newcode2048 pkg/compiler/lib/src/elements/modelx.dart:2048: this.definingConstructor, On 2015/04/10 13:37:16, Johnni Winther wrote: > Bad ...
5 years, 8 months ago (2015-04-13 07:35:18 UTC) #5
sigurdm
Committed patchset #2 (id:40001) manually as 45086 (presubmit successful).
5 years, 8 months ago (2015-04-13 07:56:42 UTC) #6
karlklose
https://codereview.chromium.org/1019923005/diff/40001/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1019923005/diff/40001/pkg/compiler/lib/src/deferred_load.dart#newcode320 pkg/compiler/lib/src/deferred_load.dart:320: type.element.alias; Add the type's element to elements? Shouldn't this ...
5 years, 8 months ago (2015-04-13 08:10:57 UTC) #8
sigurdm
Reverted in r45086 PTAL https://codereview.chromium.org/1019923005/diff/40001/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1019923005/diff/40001/pkg/compiler/lib/src/deferred_load.dart#newcode320 pkg/compiler/lib/src/deferred_load.dart:320: type.element.alias; On 2015/04/13 08:10:57, karlklose ...
5 years, 8 months ago (2015-04-13 13:37:08 UTC) #9
Johnni Winther
lgtm
5 years, 8 months ago (2015-04-13 13:42:38 UTC) #10
sigurdm
Committed patchset #3 (id:60001) manually as 45101 (presubmit successful).
5 years, 8 months ago (2015-04-13 13:53:22 UTC) #11
karlklose
https://codereview.chromium.org/1019923005/diff/60001/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1019923005/diff/60001/pkg/compiler/lib/src/deferred_load.dart#newcode321 pkg/compiler/lib/src/deferred_load.dart:321: collectTypeDependencies(type.unalias(compiler)); Is there a test that caught this missing ...
5 years, 8 months ago (2015-04-13 15:54:11 UTC) #12
sigurdm
PTAL https://codereview.chromium.org/1019923005/diff/60001/pkg/compiler/lib/src/deferred_load.dart File pkg/compiler/lib/src/deferred_load.dart (right): https://codereview.chromium.org/1019923005/diff/60001/pkg/compiler/lib/src/deferred_load.dart#newcode321 pkg/compiler/lib/src/deferred_load.dart:321: collectTypeDependencies(type.unalias(compiler)); On 2015/04/13 15:54:10, karlklose wrote: > Is ...
5 years, 8 months ago (2015-04-14 11:26:35 UTC) #13
Johnni Winther
lgtm
5 years, 8 months ago (2015-04-14 11:52:10 UTC) #14
sigurdm
Added one more test-case could you take one more quick look?
5 years, 8 months ago (2015-04-15 10:28:40 UTC) #15
Johnni Winther
Still LGTM
5 years, 8 months ago (2015-04-15 10:36:45 UTC) #16
sigurdm
5 years, 8 months ago (2015-04-15 10:55:52 UTC) #17
Message was sent while issue was closed. 
Committed patchset #6 (id:120001) manually as 45159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698