Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1019903002: Revert "Don't generate forwarding hooks if all noSuchMethod implementations" (Closed)

Created:
5 years, 9 months ago by Harry Terkelsen
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Don't generate forwarding hooks if all noSuchMethod implementations" This reverts commit r44575. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -369 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 3 chunks +11 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 5 chunks +10 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +3 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +0 lines, -163 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/compiler/dart2js/no_such_method_enabled_test.dart View 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Harry Terkelsen
5 years, 9 months ago (2015-03-19 16:33:51 UTC) #2
floitsch
LGTM. Please update the revision number to the SVN revision.
5 years, 9 months ago (2015-03-19 16:39:34 UTC) #5
Harry Terkelsen
5 years, 9 months ago (2015-03-19 16:44:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698