Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1019853002: Document and fix HTML-escape. (Closed)

Created:
5 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Søren Gjesse, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Document and fix HTML-escape. Update documentation and behavior of HtmlEscape. BUG= http://dartbug.com/21913, http://dartbug.com/13097 R=floitsch@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45003

Patch Set 1 #

Patch Set 2 : Make constructor public. #

Total comments: 6

Patch Set 3 : address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -38 lines) Patch
M sdk/lib/convert/html_escape.dart View 1 2 2 chunks +122 lines, -31 lines 0 comments Download
M tests/lib/convert/html_escape_test.dart View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-19 13:44:19 UTC) #2
Søren Gjesse
lgtm https://codereview.chromium.org/1019853002/diff/20001/sdk/lib/convert/html_escape.dart File sdk/lib/convert/html_escape.dart (right): https://codereview.chromium.org/1019853002/diff/20001/sdk/lib/convert/html_escape.dart#newcode14 sdk/lib/convert/html_escape.dart:14: * where the escaped result is going to ...
5 years, 9 months ago (2015-03-19 14:09:33 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/1019853002/diff/20001/sdk/lib/convert/html_escape.dart File sdk/lib/convert/html_escape.dart (right): https://codereview.chromium.org/1019853002/diff/20001/sdk/lib/convert/html_escape.dart#newcode94 sdk/lib/convert/html_escape.dart:94: * Converter which escapes characters that means something ...
5 years, 9 months ago (2015-03-19 14:10:39 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/1019853002/diff/20001/sdk/lib/convert/html_escape.dart File sdk/lib/convert/html_escape.dart (right): https://codereview.chromium.org/1019853002/diff/20001/sdk/lib/convert/html_escape.dart#newcode14 sdk/lib/convert/html_escape.dart:14: * where the escaped result is going to be ...
5 years, 9 months ago (2015-03-20 08:47:05 UTC) #5
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-09 12:45:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45003 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698