Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1019793012: Fix --break_at_isolate_spawn. Starting in r44655 implicit static closure function are not themselve… (Closed)

Created:
5 years, 9 months ago by rmacnak
Modified:
5 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix --break_at_isolate_spawn. Starting in r44655 implicit static closure functions are not themselves debuggable, so set the breakpoint on the static function they will dispatch to instead. BUG= R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=44712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M runtime/vm/isolate.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 9 months ago (2015-03-25 23:18:57 UTC) #2
turnidge
lgtm
5 years, 9 months ago (2015-03-26 16:38:44 UTC) #3
rmacnak
5 years, 9 months ago (2015-03-26 17:19:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698