Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 101913008: Add argument checking to InternetAddress constructor (Closed)

Created:
7 years ago by Søren Gjesse
Modified:
7 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add argument checking to InternetAddress constructor R=ajohnsen@google.com BUG=http://dartbug.com/15687 Committed: https://code.google.com/p/dart/source/detail?r=31220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/internet_address_test.dart View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years ago (2013-12-18 09:20:06 UTC) #1
Anders Johnsen
lgtm
7 years ago (2013-12-18 10:10:41 UTC) #2
Søren Gjesse
7 years ago (2013-12-18 11:26:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698