Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1018443003: Start analyzing LibraryUnitTarget(s) from BuildLibraryElementTask. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Start analyzing LibraryUnitTarget(s) from BuildLibraryElementTask. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -61 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 8 chunks +65 lines, -28 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +4 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-16 22:13:35 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-16 22:42:44 UTC) #2
scheglov
5 years, 9 months ago (2015-03-16 23:39:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698