Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1018393003: Rename the inner function of async functions. (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Rename the inner function of async functions. Before they were all named `body`, now they have the same name as their enclosing function. BUG= dartbug.com/22942 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 6 chunks +16 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/async_await_js_transform_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
sigurdm
5 years, 9 months ago (2015-03-23 14:48:29 UTC) #2
floitsch
LGTM.
5 years, 9 months ago (2015-03-23 16:01:16 UTC) #3
sigurdm
5 years, 9 months ago (2015-03-25 12:37:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698