Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1018373002: Re-enable and adjust skipped VM debugger tests. (Closed)

Created:
5 years, 9 months ago by Florian Schneider
Modified:
5 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Re-enable and adjust skipped VM debugger tests. They were skipped because of a long-resolved issue. This required changing the set of reported variables according to the current debugger implementation. I adjusted the test to check for substring for the expected function names: Dart_ActivationFrameGetLocation returns Debugger::QualifiedFunctionName nad and Dart_FunctionName returns Function::UserVisibleName. Should the two be made consistent instead? cc/IsolateInterrupt was skipped on x64 for unknown reasons. It seems to pass fine (tested locally) R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 5 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 9 months ago (2015-03-19 15:51:31 UTC) #2
hausner
LGTM. I wouldn't change the different function name APIs. I certainly would not make the ...
5 years, 9 months ago (2015-03-19 16:22:30 UTC) #3
Florian Schneider
5 years, 9 months ago (2015-03-20 09:25:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698