Chromium Code Reviews

Issue 1017813002: pkg/unittest: fix a broken test and update status files (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, nweiz
Base URL:
https://github.com/dart-lang/unittest.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : cl nit #

Unified diffs Side-by-side diffs Stats (+4 lines, -4 lines)
M .status View 1 chunk +3 lines, -3 lines 0 comments
M test/util/parse_annotations_test.dart View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 9 months ago (2015-03-17 19:51:45 UTC) #2
Bob Nystrom
One thing then LGTM. https://codereview.chromium.org/1017813002/diff/1/test/util/parse_annotations_test.dart File test/util/parse_annotations_test.dart (right): https://codereview.chromium.org/1017813002/diff/1/test/util/parse_annotations_test.dart#newcode100 test/util/parse_annotations_test.dart:100: print([args[1], args[1].runtimeType]); Delete this.
5 years, 9 months ago (2015-03-17 19:55:25 UTC) #3
kevmoo
https://codereview.chromium.org/1017813002/diff/1/test/util/parse_annotations_test.dart File test/util/parse_annotations_test.dart (right): https://codereview.chromium.org/1017813002/diff/1/test/util/parse_annotations_test.dart#newcode100 test/util/parse_annotations_test.dart:100: print([args[1], args[1].runtimeType]); On 2015/03/17 19:55:25, Bob Nystrom wrote: > ...
5 years, 9 months ago (2015-03-17 19:57:00 UTC) #4
kevmoo
5 years, 9 months ago (2015-03-17 19:57:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
788bc8945f4a3ef3d07cae6a3656ce340f85173d (presubmit successful).

Powered by Google App Engine