Issue 1017573004: Rewrite constants evaluation and checks to avoid using 'is double'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1017573004: Rewrite constants evaluation and checks to avoid using 'is double'. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Rewrite constants evaluation and checks to avoid using 'is double'. We have 33 hints because of it. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44724

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -122 lines)			Patch
	M	pkg/analyzer/lib/src/generated/ast.dart	View		6 chunks	+14 lines, -52 lines	0 comments	Download
	M	pkg/analyzer/test/generated/ast_test.dart	View		16 chunks	+46 lines, -70 lines	0 comments	Download

Total messages: 4 (0 generated)

scheglov

5 years, 9 months ago (2015-03-26 22:45:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44724 (presubmit successful).