Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1017323004: Autoselect a port rather than always using 8080 for chrome_test. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Autoselect a port rather than always using 8080 for chrome_test. Closes #37 R=rnystrom@google.com Committed: https://github.com/dart-lang/unittest/commit/ab7bff62f4b7c2d63a256791c3d6b9125f9f3509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/runner/browser/chrome_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 9 months ago (2015-03-23 20:00:55 UTC) #1
Bob Nystrom
lgtm
5 years, 9 months ago (2015-03-23 20:01:37 UTC) #2
nweiz
5 years, 9 months ago (2015-03-23 22:57:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab7bff62f4b7c2d63a256791c3d6b9125f9f3509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698