Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1016973002: Move CHA state keeping from Isolate to Thread. (Closed)

Created:
5 years, 9 months ago by koda
Modified:
5 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Move CHA state keeping from Isolate to Thread. This prepares for the Isolate/Thread split, and also enables us to remove the GrowableArray(Isolate*) interface. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44549

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -36 lines) Patch
M runtime/vm/cha.h View 3 chunks +10 lines, -9 lines 0 comments Download
M runtime/vm/cha.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/cha_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/growable_array.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/thread.h View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 9 months ago (2015-03-17 23:16:46 UTC) #1
srdjan
lgtm
5 years, 9 months ago (2015-03-17 23:51:03 UTC) #2
koda
5 years, 9 months ago (2015-03-18 00:29:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r44549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698