Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1016833002: Fix await/async/yield keyword recognition (Closed)

Created:
5 years, 9 months ago by hausner
Modified:
5 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, sigurdm
Visibility:
Public.

Description

Fix await/async/yield keyword recognition Fixes issue 22870. The VM parser didn’t distinguish between await and “await”. Added some additional symbol recognition cleanup which should speed up parsing. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -33 lines) Patch
M runtime/vm/parser.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 19 chunks +31 lines, -32 lines 0 comments Download
M runtime/vm/symbols.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 9 months ago (2015-03-17 17:15:20 UTC) #2
srdjan
lgtm
5 years, 9 months ago (2015-03-17 17:26:23 UTC) #3
hausner
5 years, 9 months ago (2015-03-17 17:27:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44540 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698