Make sure File_WriteFrom write all data unless an error occour

Make sure File_WriteFrom write all data unless an error occour

Signals can interrupt write before all requested data is written.

R=ajohnsen@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44570

[Anders Johnsen, 2015-03-18 10:11:14]

LGTM, with comments.

https://codereview.chromium.org/1015763002/diff/20001/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://codereview.chromium.org/1015763002/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:272: int64_t written = file->Write(buffer, remaining);
Use file->WriteFully instead?

https://codereview.chromium.org/1015763002/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:1106: file->Write(reinterpret_cast<void*>(buffer_start),
length);
Problem here too?

[Søren Gjesse, 2015-03-19 10:12:45]

https://codereview.chromium.org/1015763002/diff/20001/runtime/bin/file.cc
File runtime/bin/file.cc (right):

https://codereview.chromium.org/1015763002/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:272: int64_t written = file->Write(buffer, remaining);
On 2015/03/18 10:11:13, Anders Johnsen wrote:
> Use file->WriteFully instead?

Forgot about that. Done.

https://codereview.chromium.org/1015763002/diff/20001/runtime/bin/file.cc#new...
runtime/bin/file.cc:1106: file->Write(reinterpret_cast<void*>(buffer_start),
length);
On 2015/03/18 10:11:13, Anders Johnsen wrote:
> Problem here too?

Yes. Fixed here as well. Also did it for the write byte methods.

[Søren Gjesse, 2015-03-19 10:13:33]

Committed patchset #3 (id:40001) manually as 44570 (presubmit successful).