Issue 101523003: Add chain support to barback.

Issue 101523003: Add chain support to barback. (Closed)

Created:
7 years ago by nweiz

Modified:
7 years ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add chain support to barback. This also adds support to pub where necessary to maintain consistency with barback. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30880

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -64 lines)			Patch
M	pkg/barback/lib/src/asset_cascade.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/asset_node.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/build_result.dart	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	pkg/barback/lib/src/errors.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/barback/lib/src/file_pool.dart	View		2 chunks	+3 lines, -1 line	1 comment	Download
M	pkg/barback/lib/src/internal_asset.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/barback/lib/src/package_graph.dart	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/phase_input.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/pool.dart	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/serialize.dart	View	1	2 chunks	+8 lines, -15 lines	0 comments	Download
M	pkg/barback/lib/src/utils.dart	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/dart.dart	View	1	2 chunks	+8 lines, -15 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/pool.dart	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

https://codereview.chromium.org/101523003/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart (right): https://codereview.chromium.org/101523003/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart#newcode314 sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart:314: /// [error] should be the result of [CrossIsolateException.serialize]. Update ...

7 years ago (2013-12-04 17:37:21 UTC) #2

nweiz

7 years ago (2013-12-04 22:41:30 UTC) #3

Siggi Cherem (dart-lang)

7 years ago (2013-12-09 18:58:33 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/101523003/diff/20001/pkg/barback/lib/src/file...
File pkg/barback/lib/src/file_pool.dart (right):

https://codereview.chromium.org/101523003/diff/20001/pkg/barback/lib/src/file...
pkg/barback/lib/src/file_pool.dart:38: return Chain.track(new
File(path).openRead()).transform(
I just noticed that this breaks polymer build: this is a new API that is not
available yet in the hosted stack_trace package. We need to upload a new version
of stack_trace, and add a dependence in backback to make sure we get that
version.

Expand Messages | Collapse Messages