Issue 1014473006: Profiler fixes for 1.9

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1014473006: Profiler fixes for 1.9 (Closed)

Created:
5 years, 9 months ago by Cutch

Modified:
5 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Profiler fixes for 1.9 - Make the first level of a non-VM tree % consistent with self % - Always tick the [Truncated] tag for inclusive trees. - Don't show call tree direction drop down at all. - Additional tracing. Committed: https://code.google.com/p/dart/source/detail?r=44525

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Patch Set 6 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -36 lines)			Patch
	M	runtime/observatory/lib/src/elements/cpu_profile.html	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
	M	runtime/vm/profiler_service.cc	View	1 2 3 4 5	20 chunks	+119 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

LGTMwC -Ivan https://codereview.chromium.org/1014473006/diff/60001/runtime/vm/profiler_service.cc File runtime/vm/profiler_service.cc (right): https://codereview.chromium.org/1014473006/diff/60001/runtime/vm/profiler_service.cc#newcode1546 runtime/vm/profiler_service.cc:1546: CodeRegion* region = tag_code_table_->At(index); I am wondering ...

5 years, 9 months ago (2015-03-16 22:17:37 UTC) #3

Cutch

5 years, 9 months ago (2015-03-16 22:21:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 (id:100001) manually as 44525 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages