Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1014023002: Add tests for constants from deferred loaded libraries being readable. (Closed)

Created:
5 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 9 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add tests for constants from deferred loaded libraries being readable. The spec says that the constant declarations accessed through a deferred prefix are not compile time constant expressions, but they should still be accessible as normal expressions. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=44554

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add issue number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A tests/language/deferred_load_constants.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/deferred_load_constants_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-17 13:57:02 UTC) #2
sigurdm
LGTM
5 years, 9 months ago (2015-03-17 14:09:02 UTC) #3
sigurdm
LGTM
5 years, 9 months ago (2015-03-17 14:09:03 UTC) #4
sigurdm
https://codereview.chromium.org/1014023002/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/1014023002/diff/1/tests/language/language_dart2js.status#newcode13 tests/language/language_dart2js.status:13: deferred_load_constants_test/none: CompileTimeError Should probably have an issue id
5 years, 9 months ago (2015-03-17 14:09:59 UTC) #5
Lasse Reichstein Nielsen
5 years, 9 months ago (2015-03-18 10:36:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698