Issue 1013933002: Test that catch variables are marked as final.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1013933002: Test that catch variables are marked as final. (Closed)

Created:
5 years, 9 months ago by hausner

Modified:
5 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Test that catch variables are marked as final. See new test cases language/try_catch_on_synatx_test/10 and language/try_catch_on_synatx_test/11. Dart2js fails the test. Issue 19823. Committed: https://code.google.com/p/dart/source/detail?r=44537

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -25 lines)			Patch
	M	tests/language/language_dart2js.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tests/language/try_catch_on_syntax_test.dart	View		1 chunk	+30 lines, -25 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

Committed patchset #1 (id:1) manually as r44537 (presubmit successful).

5 years, 9 months ago (2015-03-17 15:46:14 UTC) #3

floitsch

5 years, 7 months ago (2015-05-08 01:31:12 UTC) #5

Message was sent while issue was closed.

LGTM (although I still think that it shouldn't be final).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages