Issue 1013883002: Notification test passes on Safari, on the basis that it's not supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1013883002: Notification test passes on Safari, on the basis that it's not supported. (Closed)

Created:
5 years, 9 months ago by Alan Knight

Modified:
5 years, 9 months ago

Reviewers:
terry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Notification test passes on Safari, on the basis that it's not supported. BUG= Committed: https://code.google.com/p/dart/source/detail?r=44527

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/html/html.status	View	1	3 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Alan Knight

Because there's a conditional in the test based on Notification.supported, it actually passes on Safari ...

5 years, 9 months ago (2015-03-16 23:25:00 UTC) #2

Alan Knight

5 years, 9 months ago (2015-03-16 23:25:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44527 (presubmit successful).