Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1013753015: Limit the length of file paths used in many_files_test. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Limit the length of file paths used in many_files_test. Windows and OS X have pretty strict limits on how long a path can be. R=rnystrom@google.com BUG= dartbug.com/22878 Committed: https://code.google.com/p/dart/source/detail?r=44676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M sdk/lib/_internal/pub/test/lish/many_files_test.dart View 2 chunks +26 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 9 months ago (2015-03-24 18:14:46 UTC) #1
Bob Nystrom
LGTM. Passes fine on my Mac.
5 years, 9 months ago (2015-03-24 20:25:03 UTC) #2
nweiz
5 years, 9 months ago (2015-03-24 21:57:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698