Issue 1013733002: Fix assembling of paddd, psubd instructions on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1013733002: Fix assembling of paddd, psubd instructions on x64. (Closed)

Created:
5 years, 9 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 9 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix assembling of paddd, psubd instructions on x64. 0x66 prefix must preceede REX prefixes. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44505

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -4 lines)			Patch
	M	runtime/vm/assembler_x64.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	M	runtime/vm/assembler_x64_test.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Google)

5 years, 9 months ago (2015-03-16 15:00:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44505 (presubmit successful).