Issue 1012993004: Task: Build Export Source Closure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1012993004: Task: Build Export Source Closure. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Task: Build Export Source Closure. It's result will be used later to compute EXPORT_NAMESPACE for each library. One of the inputs of the task computing EXPORT_NAMESPACE is a map of each source from EXPORT_SOURCE_CLOSURE to its PUBLIC_NAMESPACE. It will require also changes to NamespaceBuilder to replace direct AnalysisContext.getPublicNamespace(LibraryElement) with an externally provided function. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44535

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -1 line)			Patch
	M	pkg/analyzer/lib/src/task/dart.dart	View		6 chunks	+93 lines, -1 line	0 comments	Download
	M	pkg/analyzer/test/src/task/dart_test.dart	View		4 chunks	+52 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1012993004/diff/1/pkg/analyzer/test/src/task/dart_test.dart File pkg/analyzer/test/src/task/dart_test.dart (right): https://codereview.chromium.org/1012993004/diff/1/pkg/analyzer/test/src/task/dart_test.dart#newcode1035 pkg/analyzer/test/src/task/dart_test.dart:1035: // TODO(scheglov) Should be be replaced with an ...

5 years, 9 months ago (2015-03-17 13:52:49 UTC) #2

scheglov

5 years, 9 months ago (2015-03-17 14:54:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44535 (presubmit successful).

Expand Messages | Collapse Messages