Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1012933002: Fix do-while with await in condition (Closed)

Created:
5 years, 9 months ago by hausner
Modified:
5 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix do-while with await in condition The await “preamble” code must be part of the expression, not part of the body. Fixes issue 22777 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M runtime/vm/parser.cc View 1 chunk +8 lines, -5 lines 0 comments Download
A tests/language/regress_22777_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 9 months ago (2015-03-16 19:36:42 UTC) #2
srdjan
lgtm
5 years, 9 months ago (2015-03-16 19:54:14 UTC) #3
hausner
5 years, 9 months ago (2015-03-16 19:57:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698