Issue 1012623002: Issue 22833. Quick Assist to convert for-each into for-index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1012623002: Issue 22833. Quick Assist to convert for-each into for-index. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Issue 22833. Quick Assist to convert for-each into for-index. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22833 Committed: https://code.google.com/p/dart/source/detail?r=44507

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+294 lines, -65 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/assist.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View	4 chunks	+114 lines, -38 lines	1 comment	Download
M	pkg/analysis_server/lib/src/services/correction/util.dart	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/extract_local.dart	View	3 chunks	+3 lines, -27 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/assist_test.dart	View	1 chunk	+147 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1012623002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart File pkg/analysis_server/lib/src/services/correction/assist_internal.dart (right): https://codereview.chromium.org/1012623002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart#newcode462 pkg/analysis_server/lib/src/services/correction/assist_internal.dart:462: iterableType.element == listType.element) {} else { This is ...

5 years, 9 months ago (2015-03-16 13:54:45 UTC) #2

scheglov

5 years, 9 months ago (2015-03-16 15:06:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44507 (presubmit successful).

Expand Messages | Collapse Messages