Include the common library name used in 'part of' directives.

Include the common library name used in 'part of' directives.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44496

[Brian Wilkerson, 2015-03-15 23:28:14]

LGTM

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:250: ErrorCode errorCode, List<Object>
arguments)
Make 'arguments' optional here too?

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:623: AnalysisErrorWithProperties error = new
AnalysisErrorWithProperties.con1(
There's no point in creating an AnalysisErrorWithProperties if we're not going
to set the properties.

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:625: if (partsLibraryName !=
_UNKNOWN_LIBRARY_NAME) {
"&& partsLibraryName != null"?

I'm guessing we don't want to set the property to null.

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:573: AnalysisErrorWithProperties error
= errorListener.errors[0];
"AnalysisErrorWithProperties" --> "AnalysisError"

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:592: AnalysisErrorWithProperties error
= errorListener.errors[0];
"AnalysisErrorWithProperties" --> "AnalysisError"

[scheglov, 2015-03-15 23:38:16]

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:250: ErrorCode errorCode, List<Object>
arguments)
On 2015/03/15 23:28:14, Brian Wilkerson wrote:
> Make 'arguments' optional here too?

Done.

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:623: AnalysisErrorWithProperties error = new
AnalysisErrorWithProperties.con1(
On 2015/03/15 23:28:14, Brian Wilkerson wrote:
> There's no point in creating an AnalysisErrorWithProperties if we're not going
> to set the properties.

Done.

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:625: if (partsLibraryName !=
_UNKNOWN_LIBRARY_NAME) {
On 2015/03/15 23:28:14, Brian Wilkerson wrote:
> "&& partsLibraryName != null"?
> 
> I'm guessing we don't want to set the property to null.

Done.

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:573: AnalysisErrorWithProperties error
= errorListener.errors[0];
On 2015/03/15 23:28:14, Brian Wilkerson wrote:
> "AnalysisErrorWithProperties" --> "AnalysisError"

Done.

https://codereview.chromium.org/1012543002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:592: AnalysisErrorWithProperties error
= errorListener.errors[0];
On 2015/03/15 23:28:14, Brian Wilkerson wrote:
> "AnalysisErrorWithProperties" --> "AnalysisError"

Done.

[scheglov, 2015-03-15 23:38:40]

Committed patchset #2 (id:20001) manually as 44496 (presubmit successful).