Task: Build Type Aliases.

Task: Build Type Aliases.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44565

[Brian Wilkerson, 2015-03-18 14:34:05]

https://codereview.chromium.org/1012403002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1012403002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9005: LibraryScope(LibraryElement
definingLibrary, Scope importScope,
This is a breaking change for other clients and makes the existing clients of
this constructor harder to read. It should also be a temporary change because
eventually there should only need to be one kind of library import scope.

How about adding a named constructor (marked as 'deprecated') for this case and
leaving this constructor as it was?

https://codereview.chromium.org/1012403002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:10215:
ResolverVisitor.con2(LibraryElement definingLibrary, Scope libraryScope,
Should this be "LibraryScope libraryScope"? If not, then perhaps "Scope
resolutionScope" or something that doesn't imply that it should have been a
library scope? (I see this same problem in several other places as well.)

[scheglov, 2015-03-18 19:43:18]

PTAL

[Brian Wilkerson, 2015-03-18 19:47:29]

LGTM!

[scheglov, 2015-03-18 20:49:36]

Committed patchset #2 (id:20001) manually as 44565 (presubmit successful).