Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1011613002: Issue 22845. Rename should prevent the use of invalid identifiers. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart View 4 chunks +12 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-15 19:13:43 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-15 19:23:00 UTC) #2
scheglov
5 years, 9 months ago (2015-03-15 19:56:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44495 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698