Issue 101153005: Implement GetNativeReceiver without handles under a NoGCScope, this should

Issue 101153005: Implement GetNativeReceiver without handles under a NoGCScope, this should (Closed)

Created:
6 years, 11 months ago by siva

Modified:
6 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement GetNativeReceiver without handles under a NoGCScope, this should eliminate the hot InitializeHandle calls that were observed in the profile. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31405

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -16 lines)			Patch
M	runtime/vm/dart_api_impl.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		2 chunks	+27 lines, -16 lines	0 comments	Download
M	runtime/vm/raw_object.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/101153005/diff/1/runtime/vm/dart_api_impl.h File runtime/vm/dart_api_impl.h (right): https://codereview.chromium.org/101153005/diff/1/runtime/vm/dart_api_impl.h#newcode214 runtime/vm/dart_api_impl.h:214: intptr_t* value); one line? https://codereview.chromium.org/101153005/diff/1/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): ...

6 years, 11 months ago (2013-12-30 18:35:19 UTC) #2

siva

https://codereview.chromium.org/101153005/diff/1/runtime/vm/dart_api_impl.h File runtime/vm/dart_api_impl.h (right): https://codereview.chromium.org/101153005/diff/1/runtime/vm/dart_api_impl.h#newcode214 runtime/vm/dart_api_impl.h:214: intptr_t* value); On 2013/12/30 18:35:19, srdjan wrote: > one ...

6 years, 11 months ago (2013-12-30 19:39:49 UTC) #3

siva

6 years, 11 months ago (2013-12-30 19:55:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31405 (presubmit successful).

Expand Messages | Collapse Messages