Issue 1010743005: Add regression test for Map compaction issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1010743005: Add regression test for Map compaction issue. (Closed)

Created:
5 years, 9 months ago by koda

Modified:
5 years, 9 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add regression test for Map compaction issue. Original fix for the issue: https://code.google.com/p/dart/source/detail?r=44671 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=44702

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	A	tests/standalone/map_literal_oom_test.dart	View		1 chunk	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM https://codereview.chromium.org/1010743005/diff/1/tests/standalone/map_literal_oom_test.dart File tests/standalone/map_literal_oom_test.dart (right): https://codereview.chromium.org/1010743005/diff/1/tests/standalone/map_literal_oom_test.dart#newcode10 tests/standalone/map_literal_oom_test.dart:10: for (int i = 0; i < 1000000000; ...

5 years, 9 months ago (2015-03-25 09:19:27 UTC) #2

koda

Committed patchset #1 (id:1) manually as r44702 (presubmit successful).

5 years, 9 months ago (2015-03-25 22:26:16 UTC) #3

koda

5 years, 9 months ago (2015-03-25 22:26:35 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1010743005/diff/1/tests/standalone/map_litera...
File tests/standalone/map_literal_oom_test.dart (right):

https://codereview.chromium.org/1010743005/diff/1/tests/standalone/map_litera...
tests/standalone/map_literal_oom_test.dart:10: for (int i = 0; i < 1000000000;
i++) {
On 2015/03/25 09:19:26, kustermann wrote:
> You could remove two '0's, since the test might time out on some architectures
> otherwise (mips/arm simulator/hardware are pretty slow I think).
> 

Done.

Expand Messages | Collapse Messages