Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1010493006: Use _nextLink instead of _next for better type inferencing. (Closed)

Created:
5 years, 9 months ago by sra1
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use _nextLink instead of _next for better type inferencing. This recovers ~400 of the ~1400 byte regression on r44451. The _next field was inferred as Union of [[null|exact=LinkedHashSetCell], [null|subclass=_DoubleLink]] Another way to fix this issue would be to make queue.dart a sub-library. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=44508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M sdk/lib/collection/queue.dart View 11 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
5 years, 9 months ago (2015-03-16 12:49:57 UTC) #2
Lasse Reichstein Nielsen
lgtm
5 years, 9 months ago (2015-03-16 14:07:49 UTC) #3
sra1
5 years, 9 months ago (2015-03-16 15:11:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44508 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698