Remove NSM if followed by a foreign with same effect.~

Remove NSM if followed by a foreign with same effect.

BUG=
R=floitsch@google.com, sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44661

Reverted: https://code.google.com/p/dart/source/detail?r=44662

Committed: https://code.google.com/p/dart/source/detail?r=44663

[herhut, 2015-03-19 13:20:32]

herhut@google.com changed reviewers:
+ sra@google.com

[floitsch, 2015-03-23 00:48:37]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-03-23 00:48:39]

LGTM.

https://codereview.chromium.org/1010433004/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/1010433004/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:1006: bool templateThrowsNSM(HForeignCode
foreign, HInstruction receiver) {
templateThrowsNsmOnNull

[sra1, 2015-03-23 01:06:43]

lgtm, but I'd rather see a formulation where the property 'throws nsm on null
first template parameter' is factored from the SSA representation and can be
reused in cps_ir.

[herhut, 2015-03-24 11:31:13]

On 2015/03/23 01:06:43, sra1 wrote:
> lgtm, but I'd rather see a formulation where the property 'throws nsm on null
> first template parameter' is factored from the SSA representation and can be
> reused in cps_ir.

I talked to Kevin and the foreign in cps-ir story is not yet cooked well. We
agreed not to refactor this until we actually know what it will look like in
cps-ir.

[herhut, 2015-03-24 11:31:43]

https://codereview.chromium.org/1010433004/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/1010433004/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:1006: bool templateThrowsNSM(HForeignCode
foreign, HInstruction receiver) {
On 2015/03/23 00:48:38, floitsch wrote:
> templateThrowsNsmOnNull

Done.

[herhut, 2015-03-24 11:32:34]

Committed patchset #2 (id:20001) manually as 44661 (presubmit successful).

[herhut, 2015-03-24 12:30:16]

Committed patchset #3 (id:40001) manually as 44663 (presubmit successful).