add from option to run

add from option to run

R=sigmund@google.com

Committed: https://github.com/dart-lang/initialize/commit/ce619b28e35cc0885188b27658ad1bb2024ae5d4

[jakemac, 2015-03-23 20:14:17]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-03-23 20:25:55]

very nice!

https://codereview.chromium.org/1008533003/diff/1/lib/initialize.dart
File lib/initialize.dart (right):

https://codereview.chromium.org/1008533003/diff/1/lib/initialize.dart#newcode19
lib/initialize.dart:19: /// library at the supplied uri. This option will throw
once transformed since
let's rephrase this last sentence a bit, to make it clear how this affects an
average user of the initialize package. One idea:

**Do not use this argument** directly in your code unless you are building a
framework that will use a transformer to remove this argument later. This
parameter is supported in Dartium, but [run] will throw if you use the argument
after building an application with `pub build`.

https://codereview.chromium.org/1008533003/diff/1/lib/src/mirror_loader.dart
File lib/src/mirror_loader.dart (right):

https://codereview.chromium.org/1008533003/diff/1/lib/src/mirror_loader.dart#...
lib/src/mirror_loader.dart:60: //
https://github.com/dart-lang/initialize/issues/25
Now that we have `from:`, we can go ahead and delete this portion of the code
and make `initialize` once more independent of Dartium, yay! :)

https://codereview.chromium.org/1008533003/diff/1/lib/src/static_loader.dart
File lib/src/static_loader.dart (right):

https://codereview.chromium.org/1008533003/diff/1/lib/src/static_loader.dart#...
lib/src/static_loader.dart:29: throw 'The `from` option is not supported in the
static loader.';
mmm... I wonder if we can use some other wording for "the static loader", since
it is an implementation detail and not necessarily something the end-user knows.
One idea: " ... not supported in deploy mode" ?

[jakemac, 2015-03-23 20:58:04]

https://codereview.chromium.org/1008533003/diff/1/lib/initialize.dart
File lib/initialize.dart (right):

https://codereview.chromium.org/1008533003/diff/1/lib/initialize.dart#newcode19
lib/initialize.dart:19: /// library at the supplied uri. This option will throw
once transformed since
On 2015/03/23 20:25:55, Siggi Cherem (dart-lang) wrote:
> let's rephrase this last sentence a bit, to make it clear how this affects an
> average user of the initialize package. One idea:
> 
> **Do not use this argument** directly in your code unless you are building a
> framework that will use a transformer to remove this argument later. This
> parameter is supported in Dartium, but [run] will throw if you use the
argument
> after building an application with `pub build`. 

Done.

https://codereview.chromium.org/1008533003/diff/1/lib/src/mirror_loader.dart
File lib/src/mirror_loader.dart (right):

https://codereview.chromium.org/1008533003/diff/1/lib/src/mirror_loader.dart#...
lib/src/mirror_loader.dart:60: //
https://github.com/dart-lang/initialize/issues/25
On 2015/03/23 20:25:55, Siggi Cherem (dart-lang) wrote:
> Now that we have `from:`, we can go ahead and delete this portion of the code
> and make `initialize` once more independent of Dartium, yay! :)

done, and bumped version to a breaking change

https://codereview.chromium.org/1008533003/diff/1/lib/src/static_loader.dart
File lib/src/static_loader.dart (right):

https://codereview.chromium.org/1008533003/diff/1/lib/src/static_loader.dart#...
lib/src/static_loader.dart:29: throw 'The `from` option is not supported in the
static loader.';
On 2015/03/23 20:25:55, Siggi Cherem (dart-lang) wrote:
> mmm... I wonder if we can use some other wording for "the static loader",
since
> it is an implementation detail and not necessarily something the end-user
knows.
> One idea: " ... not supported in deploy mode" ?

Done.

[Siggi Cherem (dart-lang), 2015-03-23 21:01:14]

lgtm!

[jakemac, 2015-03-23 21:44:55]

Committed patchset #2 (id:20001) manually as
ce619b28e35cc0885188b27658ad1bb2024ae5d4 (presubmit successful).