Add a function to parse metadata into a usable object.

Add a function to parse metadata into a usable object.

See #6

R=rnystrom@google.com

Committed: https://github.com/dart-lang/unittest/commit/b868624b373f25140abbfeea940013214e462bfc

[Bob Nystrom, 2015-03-12 21:03:21]

https://codereview.chromium.org/1008483003/diff/1/lib/src/backend/metadata.dart
File lib/src/backend/metadata.dart (right):

https://codereview.chromium.org/1008483003/diff/1/lib/src/backend/metadata.da...
lib/src/backend/metadata.dart:13: final String testOn;
Why is this a String and not a TestOn?

https://codereview.chromium.org/1008483003/diff/1/lib/src/runner/parse_metada...
File lib/src/runner/parse_metadata.dart (right):

https://codereview.chromium.org/1008483003/diff/1/lib/src/runner/parse_metada...
lib/src/runner/parse_metadata.dart:25: // to resolve this ambiguity, so we just
assume that unittest annotations
Given that you are parsing the directives now, this doesn't seem like a problem.

I worry that silently dropping an annotation on the floor if it has a prefix
will cause problems for users.

https://codereview.chromium.org/1008483003/diff/1/lib/src/runner/parse_metada...
lib/src/runner/parse_metadata.dart:77: "TestOn takes a String.",
_spanFor(args.first, path));
Since you don't handle adjacent strings (which is fine), it might be good to be
explicit here like "single String literal".

[nweiz, 2015-03-12 23:39:39]

Code review changes

[nweiz, 2015-03-12 23:40:22]

I got rid of parse_annotations_test, since the code it was testing got rolled
into parseMetadata and it was testing code external to this package anyway.

https://codereview.chromium.org/1008483003/diff/1/lib/src/backend/metadata.dart
File lib/src/backend/metadata.dart (right):

https://codereview.chromium.org/1008483003/diff/1/lib/src/backend/metadata.da...
lib/src/backend/metadata.dart:13: final String testOn;
On 2015/03/12 21:03:21, Bob Nystrom wrote:
> Why is this a String and not a TestOn?

It should really be a PlatformSelector, actually, but that class doesn't exist
yet so I'm just using a String as a placeholder.

https://codereview.chromium.org/1008483003/diff/1/lib/src/runner/parse_metada...
File lib/src/runner/parse_metadata.dart (right):

https://codereview.chromium.org/1008483003/diff/1/lib/src/runner/parse_metada...
lib/src/runner/parse_metadata.dart:25: // to resolve this ambiguity, so we just
assume that unittest annotations
On 2015/03/12 21:03:21, Bob Nystrom wrote:
> Given that you are parsing the directives now, this doesn't seem like a
problem.
> 
> I worry that silently dropping an annotation on the floor if it has a prefix
> will cause problems for users.

Done.

https://codereview.chromium.org/1008483003/diff/1/lib/src/runner/parse_metada...
lib/src/runner/parse_metadata.dart:77: "TestOn takes a String.",
_spanFor(args.first, path));
On 2015/03/12 21:03:21, Bob Nystrom wrote:
> Since you don't handle adjacent strings (which is fine), it might be good to
be
> explicit here like "single String literal".

StringLiteral is the superclass of both adjacent strings and ccontinuous
strings.

[Bob Nystrom, 2015-03-13 16:56:43]

lgtm

[nweiz, 2015-03-24 00:50:53]

Committed patchset #2 (id:20001) manually as
b868624b373f25140abbfeea940013214e462bfc (presubmit successful).