Task: Build Directive Elements.

Task: Build Directive Elements.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44436

[Brian Wilkerson, 2015-03-12 17:56:26]

LGTM

https://codereview.chromium.org/1008433002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1008433002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:90: String _input(ResultDescriptor result,
[String suffix]) {
If this function stays, it needs a comment. But I don't see any value in it. It
isn't shorter code, and there's no requirement that the values of these fields
be the same as the name of the result that will be used to populate them. I
think this actually hurts the readability of the code.

https://codereview.chromium.org/1008433002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:360: new
SimpleTaskInput<List<Source>>(target, IMPORTED_LIBRARIES),
Personally, I like
    IMPORTED_LIBRARIES.inputFor(target)
better than
    new SimpleTaskInput<List<Source>>(target, IMPORTED_LIBRARIES)
because it's shorter.

[scheglov, 2015-03-12 18:27:00]

https://codereview.chromium.org/1008433002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1008433002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:90: String _input(ResultDescriptor result,
[String suffix]) {
On 2015/03/12 17:56:26, Brian Wilkerson wrote:
> If this function stays, it needs a comment. But I don't see any value in it.
It
> isn't shorter code, and there's no requirement that the values of these fields
> be the same as the name of the result that will be used to populate them. I
> think this actually hurts the readability of the code.

Removed.

https://codereview.chromium.org/1008433002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:360: new
SimpleTaskInput<List<Source>>(target, IMPORTED_LIBRARIES),
On 2015/03/12 17:56:26, Brian Wilkerson wrote:
> Personally, I like
>     IMPORTED_LIBRARIES.inputFor(target)
> better than
>     new SimpleTaskInput<List<Source>>(target, IMPORTED_LIBRARIES)
> because it's shorter.

Thank you.
My inputs look much better now!

[scheglov, 2015-03-12 18:27:59]

Committed patchset #1 (id:1) manually as 44436 (presubmit successful).