Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1007993002: Use AnalysisDriver to run task tests. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use AnalysisDriver to run task tests. It's much more concise now. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -386 lines) Patch
M pkg/analyzer/lib/src/task/driver.dart View 3 chunks +9 lines, -5 lines 0 comments Download
A + pkg/analyzer/test/src/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 27 chunks +184 lines, -380 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-13 21:24:41 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-13 21:52:00 UTC) #2
scheglov
5 years, 9 months ago (2015-03-13 21:58:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698