Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1007233002: Add readAsStringSync() to File. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -8 lines) Patch
M pkg/analyzer/lib/file_system/file_system.dart View 2 chunks +12 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 4 chunks +16 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-16 00:55:30 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-16 13:44:56 UTC) #2
scheglov
5 years, 9 months ago (2015-03-16 15:02:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698