Issue 1006593002: include constructor arguments in completion suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1006593002: include constructor arguments in completion suggestions (Closed)

Created:
5 years, 9 months ago by danrubel

Modified:
5 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

include constructor arguments in completion suggestions BUG=dartbug.com/22364 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44438

Patch Set 2 : merge #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -3 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/completion_test.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/local_computer_test.dart	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danrubel

https://codereview.chromium.org/1006593002/diff/1/pkg/analysis_server/test/completion_test.dart File pkg/analysis_server/test/completion_test.dart (right): https://codereview.chromium.org/1006593002/diff/1/pkg/analysis_server/test/completion_test.dart#newcode153 pkg/analysis_server/test/completion_test.dart:153: <String>["1+c", "2+c", "3+c"], failingTests: '13'); Now failing because of ...

5 years, 9 months ago (2015-03-12 18:37:07 UTC) #2

danrubel

5 years, 9 months ago (2015-03-12 18:46:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44438 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1006593002: include constructor arguments in completion suggestions (Closed)

Description

Patch Set 1 #

Patch Set 2 : merge #

Messages