Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1006513003: make sure we follow the whole super chain (Closed)

Created:
5 years, 9 months ago by jakemac
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/static-init.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M .status View 1 chunk +1 line, -0 lines 0 comments Download
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/mirror_loader.dart View 1 1 chunk +4 lines, -6 lines 0 comments Download
M lib/transformer.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
M test/initializer_parts_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A + test/initializer_super_test.dart View 1 1 chunk +14 lines, -19 lines 0 comments Download
M tool/all_tests.sh View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jakemac
5 years, 9 months ago (2015-03-18 21:31:53 UTC) #2
Siggi Cherem (dart-lang)
lgtm, oops :)
5 years, 9 months ago (2015-03-18 22:03:40 UTC) #3
jakemac
5 years, 9 months ago (2015-03-18 22:15:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
202005e52b805a03830454bfd1bc754abc89c562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698