Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 100623012: Fix pub batch files on Windows. (Closed)

Created:
7 years ago by Bob Nystrom
Modified:
7 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix pub batch files on Windows. They should handle spaces in paths correctly now. BUG=https://code.google.com/p/dart/issues/detail?id=10104 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M sdk/bin/pub.bat View 2 chunks +6 lines, -6 lines 0 comments Download
M sdk/bin/pub_developer.bat View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bob Nystrom
7 years ago (2013-12-13 19:06:54 UTC) #1
nweiz
I don't know Windows batch well enough to understand what this patch is doing. Can ...
7 years ago (2013-12-13 22:56:50 UTC) #2
Bob Nystrom
On 2013/12/13 22:56:50, nweiz wrote: > I don't know Windows batch well enough to understand ...
7 years ago (2013-12-13 23:12:42 UTC) #3
nweiz
lgtm, although I'm not a big fan of cargo-culting the line noise line.
7 years ago (2013-12-13 23:16:26 UTC) #4
Bob Nystrom
On 2013/12/13 23:16:26, nweiz wrote: > lgtm, although I'm not a big fan of cargo-culting ...
7 years ago (2013-12-14 00:08:33 UTC) #5
Bob Nystrom
7 years ago (2013-12-14 00:09:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r31150 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698