Issue 100603011: Add GrowableObjectArray::ToUserCString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100603011: Add GrowableObjectArray::ToUserCString(). (Closed)

Created:
7 years ago by turnidge

Modified:
7 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add GrowableObjectArray::ToUserCString(). Prints a decent representation of a list, subject to length constraints. Prints the length of the list if it is truncated. e.g. [] [1,2,3] ["0123456789",...](length:4) R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31144

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -35 lines)			Patch
runtime/vm/object.h	View	1 2	4 chunks	+13 lines, -3 lines	0 comments	Download
runtime/vm/object.cc	View	1 2	5 chunks	+131 lines, -29 lines	0 comments	Download
runtime/vm/object_test.cc	View	1 2	2 chunks	+54 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with nit addressed. https://codereview.chromium.org/100603011/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/100603011/diff/20001/runtime/vm/object.cc#newcode15404 runtime/vm/object.cc:15404: char trunc_suffix[16]; const intptr_t kTruncSuffixLen ...

7 years ago (2013-12-13 19:22:46 UTC) #2

turnidge

https://codereview.chromium.org/100603011/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/100603011/diff/20001/runtime/vm/object.cc#newcode15404 runtime/vm/object.cc:15404: char trunc_suffix[16]; On 2013/12/13 19:22:46, Cutch wrote: > const ...

7 years ago (2013-12-13 19:29:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r31144 (presubmit successful).

Expand Messages | Collapse Messages