Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 1005873009: Fix check for throwing NSM implementations. (Closed)

Created:
5 years, 9 months ago by Harry Terkelsen
Modified:
5 years, 9 months ago
Reviewers:
floitsch, sra1
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix check for throwing NSM implementations. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=44678

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Harry Terkelsen
5 years, 9 months ago (2015-03-24 21:47:14 UTC) #2
Harry Terkelsen
5 years, 9 months ago (2015-03-24 21:47:29 UTC) #3
Harry Terkelsen
5 years, 9 months ago (2015-03-25 00:34:06 UTC) #7
sra1
lgtm
5 years, 9 months ago (2015-03-25 00:45:13 UTC) #8
Harry Terkelsen
5 years, 9 months ago (2015-03-25 01:01:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44678 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698