Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1005483002: add completion in type argument list (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

add completion in type argument list BUG=dartbug.com/22584 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44431

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/completion/optype.dart View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +49 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
5 years, 9 months ago (2015-03-12 13:56:48 UTC) #2
scheglov
lgtm https://codereview.chromium.org/1005483002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart File pkg/analysis_server/lib/src/services/completion/optype.dart (right): https://codereview.chromium.org/1005483002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart#newcode521 pkg/analysis_server/lib/src/services/completion/optype.dart:521: } } Should this file be formatted?
5 years, 9 months ago (2015-03-12 14:52:00 UTC) #3
danrubel
https://codereview.chromium.org/1005483002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart File pkg/analysis_server/lib/src/services/completion/optype.dart (right): https://codereview.chromium.org/1005483002/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart#newcode521 pkg/analysis_server/lib/src/services/completion/optype.dart:521: } } On 2015/03/12 14:52:00, scheglov wrote: > Should ...
5 years, 9 months ago (2015-03-12 15:18:43 UTC) #4
danrubel
5 years, 9 months ago (2015-03-12 15:20:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 44431 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698