Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1004923002: Fix for issue 22778, stored the function object in the forward reference table instead of the impli… (Closed)

Created:
5 years, 9 months ago by siva
Modified:
5 years, 9 months ago
Reviewers:
regis, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix for issue 22778, stored the function object in the forward reference table instead of the implicit static closure. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44466

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M runtime/vm/snapshot.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
A tests/isolate/issue_22778_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
5 years, 9 months ago (2015-03-12 23:49:37 UTC) #2
Ivan Posva
LGTM -ip
5 years, 9 months ago (2015-03-13 15:38:01 UTC) #4
siva
Committed patchset #2 (id:20001) manually as r44466 (presubmit successful).
5 years, 9 months ago (2015-03-13 15:53:59 UTC) #5
regis
5 years, 9 months ago (2015-03-16 20:12:24 UTC) #6
Message was sent while issue was closed.
LGTM

Btw, issue 22778 is still open.

Powered by Google App Engine
This is Rietveld 408576698