Issue 1004793003: Add NOT_INITIALIZED_FIELDS property for FINAL_NOT_INITIALIZED_CONSTRUCTOR_X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1004793003: Add NOT_INITIALIZED_FIELDS property for FINAL_NOT_INITIALIZED_CONSTRUCTOR_X. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add NOT_INITIALIZED_FIELDS property for FINAL_NOT_INITIALIZED_CONSTRUCTOR_X. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44511

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+240 lines, -156 lines)			Patch
M	pkg/analyzer/lib/src/generated/error.dart	View	6 chunks	+81 lines, -14 lines	2 comments	Download
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	2 chunks	+39 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/generated/static_warning_code_test.dart	View	45 chunks	+120 lines, -137 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1004793003/diff/1/pkg/analyzer/lib/src/generated/error.dart File pkg/analyzer/lib/src/generated/error.dart (right): https://codereview.chromium.org/1004793003/diff/1/pkg/analyzer/lib/src/generated/error.dart#newcode2493 pkg/analyzer/lib/src/generated/error.dart:2493: reportErrorForOffset(errorCode, node.offset, node.length, arguments); Add ", properties" to ...

5 years, 9 months ago (2015-03-16 17:27:02 UTC) #2

scheglov

5 years, 9 months ago (2015-03-16 17:49:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44511 (presubmit successful).

Expand Messages | Collapse Messages